WebGPURenderer: Fix copyFramebufferToTexture
wrong framebuffer binding in WebGLBackend
#27593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the WebGLBackend the
copyFramebufferToTexture
was not binding the correct framebuffer.Also, the
null
binding of theREAD_FRAMEBUFFER
was throwing a WebGL warning, I removed it as anyway WebGLDRAW_FRAMEBUFFER
operation will fallback to read the window-system-provided framebuffer and work just fine. This does another error warning throw on firefox and chrome. /cc @aardgooseThis fix the new
webgpu_backdrop_water
example (error caused bycopyFramebufferToTexture
called inViewportTextureNode
).Before:
![image](https://private-user-images.githubusercontent.com/15867665/297970447-a5707b9b-d158-4b73-88fb-7dc9f5ff10ab.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNzA3OTYsIm5iZiI6MTcyNjE3MDQ5NiwicGF0aCI6Ii8xNTg2NzY2NS8yOTc5NzA0NDctYTU3MDdiOWItZDE1OC00YjczLTg4ZmItN2RjOWY1ZmYxMGFiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE5NDgxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzMzAzZGI0YWE4MjNjMDcwYzAxNjk5N2Y5Y2IxOTFmNTE3MjczMDAzMWZmMjI3YWNlZGEwNmFiYTA5OTg5NjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.iULaZ0MoRC9Zppl1S3AHSKjuZbOe4AR37AjW-Rmr_UQ)
![image](https://private-user-images.githubusercontent.com/15867665/297970492-0dada2f4-e300-434d-8152-668b3147533c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNzA3OTYsIm5iZiI6MTcyNjE3MDQ5NiwicGF0aCI6Ii8xNTg2NzY2NS8yOTc5NzA0OTItMGRhZGEyZjQtZTMwMC00MzRkLTgxNTItNjY4YjMxNDc1MzNjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE5NDgxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY3MzVmZmExMzE4MGI1OTdjYmJjNDAyZjA2MDkwNjRkY2U3ZDRlZTUwNThmNGZiNGRhMTViNGFjOTIwZjQ1ZWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.seBuXl-h2yBuTnhPMsuc5TVgorBtZhsC0rfWgYk0CVo)
After:
This contribution is funded by Utsubo