Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Fix copyFramebufferToTexture wrong framebuffer binding in WebGLBackend #27593

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

@RenaudRohlinger RenaudRohlinger commented Jan 19, 2024

In the WebGLBackend the copyFramebufferToTexture was not binding the correct framebuffer.

Also, the null binding of the READ_FRAMEBUFFER was throwing a WebGL warning, I removed it as anyway WebGL DRAW_FRAMEBUFFER operation will fallback to read the window-system-provided framebuffer and work just fine. This does another error warning throw on firefox and chrome. /cc @aardgoose

This fix the new webgpu_backdrop_water example (error caused by copyFramebufferToTexture called in ViewportTextureNode).

Before:
image
After:
image

This contribution is funded by Utsubo

@RenaudRohlinger RenaudRohlinger added this to the r161 milestone Jan 19, 2024
@sunag sunag merged commit 6c1e2c0 into mrdoob:dev Jan 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants