Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call offerSession at session end time #27368

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

cabanier
Copy link
Contributor

In a previous PR, basic support for offerSession was added.
Because offerSession's promise is fulfilled when the browser button is clicked, we need to call it again so the button can be displayed again.

cc: @Mugen87

This contribution is funded by Meta

@cabanier cabanier marked this pull request as ready for review December 12, 2023 18:09
@Mugen87 Mugen87 added this to the r160 milestone Dec 12, 2023
@Mugen87 Mugen87 merged commit f394e71 into mrdoob:dev Dec 12, 2023
11 checks passed
@cabanier cabanier deleted the offersession branch December 12, 2023 18:51
@cabanier
Copy link
Contributor Author

@Mugen87 do you know when the next release of threejs will be released?

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 14, 2023

The current planned release date is December, 20.

AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants