glTF KHR_lights update #13340
Closed
glTF KHR_lights update #13340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
requested changes
Feb 15, 2018
There was a problem hiding this comment.
Thanks, looks good! There are some merge conflicts in various pages though, you may want to cherrypick this to a new branch or rebase.
I believe it will also be necessary to set:
renderer.physicallyCorrectLights = true;... to ensure that color * intensity is interpreted as luminous intensity measured in candela.
For now I think we should consider this WIP for testing, and only merge when the KHR_lights spec is nearer to converging.
| // Handle spotlight properties. | ||
| var spot = light.spot || {}; | ||
| var innerConeAngle = spot.innerConeAngle ? spot.innerConeAngle : 0; | ||
| var outerConeAngle = spot.outerConeAngle || Math.PI / 4.0; |
There was a problem hiding this comment.
Nit: for consistency with other code here, I would write:
var innerConeAngle = spot.innerConeAngle !== undefined ? spot.innerConeAngle : 0;
var outerConeAngle = spot.outerConeAngle !== undefined ? spot.outerConeAngle : Math.PI / 4.0;There was a problem hiding this comment.
Will do.
Also opening a new pull request to clean up the PR.
|
Closing to open a clean pull request without conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to match current spec.
KhronosGroup/glTF#1223