Favor LC_ALL over LC_CTYPE in pick-test #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary when running the tests in an environment using a non UTF-8 locale. Fixes #281.
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 1 1
Lines 497 497
=======================================
Hits 448 448
Misses 49 49Continue to review full report at Codecov.
|
|
Works on ArchLabs as intended ... 👍 |
|
@DBOTW thanks for testing! |
|
@mptre , Pick is now working on Arch Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #281.
@DBOTW or @giappi could you please verify that this works as intended on Arch Linux?