Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove keypad transmit mode and hardcode cursor keys #276

Closed
wants to merge 1 commit into from
Closed

Remove keypad transmit mode and hardcode cursor keys #276

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 11, 2018

... for #275 ...

@mptre
Copy link
Owner

mptre commented Feb 11, 2018

This breaks the cursor keys in xterm for me since it now emits \e[
prefix as opposed of \eO. Instead of dropping transmit mode, can't we
just hardcode cursor keys with the \eO prefix instead? That would
requires less sync with pick.vim and no major bump.

@mptre
Copy link
Owner

mptre commented Feb 11, 2018

If this is a viable approach, I'd like to see tests for added cursor keys.

@ghost ghost closed this Feb 11, 2018
@ghost ghost deleted the nokeypad branch February 11, 2018 15:46
@ghost
Copy link
Author

ghost commented Feb 11, 2018

If this is a viable approach, I'd like to see tests for added cursor keys.

Of course (see #277) ... fortunately the tests are already there ...

@mptre
Copy link
Owner

mptre commented Feb 11, 2018

@DBOTW you're right!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mptre