Optimize redrawing of choices #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I agree in principle that this is more efficient but wonder if |
|
Using |
mptre
added a commit
that referenced
this pull request
Nov 6, 2017
Some key bindings only affect the query and unconditionally redrawing the choices is therefore a wast of time in such scenarios. Originally proposed by Jenz Guenther in PR #254.
|
Sorry for taking so long. See #264 for a slightly different approach, |
|
Thanks, I'm closing this in favor of #264 ... |
ghost
closed this
ghost
deleted the
|
Great, I'm planning on doing a release tomorrow. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... each time the cursor moves only in the input query field all choices are printed again even though nothing has changed ... this PR avoids the unnecessary redraw and saves some CPU cycles ... ;-)