Skip to content

Commit

Permalink
Remove Werror compiler flag
Browse files Browse the repository at this point in the history
It's generally considered bad practice to ship software with this flag.
Issue revealed while updating the port on OpenBSD[1].

[1] https://marc.info/?l=openbsd-ports&m=151482370923381&w=2
  • Loading branch information
mptre committed Feb 11, 2018
1 parent 805ae7c commit 8008d1e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ matrix:
include:
- os: linux
compiler: clang
env: BUILD_TYPE=default CFLAGS='-fsanitize=address -fsanitize=undefined'
env: BUILD_TYPE=default CFLAGS='-fsanitize=address -fsanitize=undefined -Werror'
- os: linux
compiler: clang-5.0
env: BUILD_TYPE=default CFLAGS='-fsanitize=address -fsanitize=undefined'
env: BUILD_TYPE=default CFLAGS='-fsanitize=address -fsanitize=undefined -Werror'
addons:
apt:
sources:
Expand All @@ -21,13 +21,13 @@ matrix:
- clang-5.0
- os: linux
compiler: gcc
env: BUILD_TYPE=default CFLAGS=-fsanitize=address
env: BUILD_TYPE=default CFLAGS='-fsanitize=address -Werror'
- os: osx
compiler: clang
env: BUILD_TYPE=default CFLAGS=-fsanitize=address
env: BUILD_TYPE=default CFLAGS='-fsanitize=address -Werror'
- os: linux
compiler: clang
env: BUILD_TYPE=coverage CFLAGS='-coverage -O0'
env: BUILD_TYPE=coverage CFLAGS='-coverage -O0 -Werror'
- os: linux
compiler: clang
env: BUILD_TYPE=coverity
Expand Down
2 changes: 1 addition & 1 deletion Makefile.am
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
AUTOMAKE_OPTIONS=foreign

AM_CFLAGS=-Wall -Werror -Wextra
AM_CFLAGS=-Wall -Wextra
AM_CPPFLAGS=-D_GNU_SOURCE

bin_PROGRAMS=pick
Expand Down

0 comments on commit 8008d1e

Please sign in to comment.