Fix component initialization and teardown #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use 'ref' or 'DisposableRefEffect' for component initialization (which runs once on entering a composition) instead of `DomSideEffect` (which runs on each recomposition). * Add component teardown, which was previously missing.
mpetuska
requested changes
Dec 1, 2021
OliverO2
commented
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix component lifecycle handling, as seems to be required according to the MDC guide:
reforDisposableRefEffectfor component initialization (which runs once on entering a composition) instead ofDomSideEffect(which runs on each recomposition).destroy(), which was previously missing.