Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gecko branch is failing tests #301

Closed
dmose opened this issue Sep 29, 2020 · 0 comments · Fixed by #303
Closed

gecko branch is failing tests #301

dmose opened this issue Sep 29, 2020 · 0 comments · Fixed by #303
Assignees
@dmose
Labels
bug Something isn't working

Comments

@dmose
Copy link
Member

dmose commented Sep 29, 2020 •
edited by data-sync-user
Loading

Happily, @linacambridge told me how to fix it, and I've got a PR forthcoming... it bumps the cargo_metadata dependency version and starts using it again.

┆Issue is synchronized with this Jira Task
dmose added a commit to dmose/uniffi-rs that referenced this issue Sep 29, 2020
@dmose
Fixes mozilla#301 cargo tests by updating and reenabling cargo_metada…
f6c7113 
…ta (mozilla#301)
linabutler added a commit that referenced this issue Sep 29, 2020
@linabutler
Merge pull request #302 from dmose/cargo-test-gekco-fail
c04dd99 
Fix #301 cargo tests by updating and reenabling cargo_metadata
dmose added a commit to dmose/uniffi-rs that referenced this issue Sep 29, 2020
@dmose
Finish the fix for mozilla#301
cafcb95
@dmose dmose linked a pull request Sep 29, 2020 that will close this issue
Finish the fix for #301 #303
Merged
@dmose dmose self-assigned this Sep 29, 2020
@dmose dmose added the bug Something isn't working label Sep 29, 2020
linabutler added a commit that referenced this issue Sep 29, 2020
@linabutler
Merge pull request #303 from dmose/cargo-test-fix-part-2
b66630c 
Finish the fix for #301
@dmose dmose closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmose dmose

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finish the fix for #301 dmose/uniffi-rs
1 participant
@dmose