Improve error message for non-existent local files #6608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I received multiple reports about the following cryptic error in the Chrome extension when the user tried to open a local file: > PDF.js v1.1.527 (build: 2096a2a) > Message: Cannot read property 'Symbol(Symbol.iterator)' of null This error most likely originated from core/stream.js: function Stream(arrayBuffer, start, length, dict) { this.bytes = (arrayBuffer instanceof Uint8Array ? arrayBuffer : new Uint8Array(arrayBuffer)); ^^^^^^^^^^^ `arrayBuffer` is `null`, and that in turn is caused by the fact that for non-existing files, there is no data. I've applied two fixes: 1. Never call onDone with a void buffer, but call the error handler instead. 2. Show a sensible error message for local files with status = 0.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/94ccb13e6db12b2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/0e1c0c68fb76ecb/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/0e1c0c68fb76ecb/output.txt Total script time: 18.61 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/94ccb13e6db12b2/output.txt Total script time: 20.26 mins
|
yurydelendik
added a commit
that referenced
this pull request
Nov 9, 2015
Improve error message for non-existent local files
|
Thank you for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I received multiple reports about the following cryptic error in the Chrome extension when the user tried to open a local file:
This error most likely originated from core/stream.js:
arrayBufferisnull, and that in turn is caused by the fact that for non-existing files, there is no data. I've applied two fixes:instead.
To get the error, simply install the Chrome extension, open any PDF file to get the extension URL, and then append some non-existent local file. E.g.
chrome-extension://oemmndcbldboiebfnladdacbdfmadadm/file:///tmp/doesnotexist.pdf