Remove PDFViewerApplication.updateScaleControls (issue 6158)
#6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*With this patch we're getting very close to fixing 6158.* The only use-case for `PDFViewerApplication.updateScaleControls` is to try and avoid calling `selectScaleOption` from the `scalechange` event handler in viewer.js. This will *only* happen when the user has manually changed the scale by using the `<select>` dropdown, which means that in reality this is just a micro optimization. Furthermore, `selectScaleOption` is only skipped for the "named" scale values (e.g. `auto`, `page-actual`, `page-fit`, `page-width`), thus further reducing the value of this code. Also, since we're updating the scale `<select>` dropdown from an event handler, we're currently depending on the event being dispatched (and handled) completely before the next `scalechange` event. Relying on the execution order of the code in this way, even though it currently works, seems unfortunate since it *could* potentially cause the internal scale value and the UI from getting out of sync.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/445ead047cd66b3/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/445ead047cd66b3/output.txt Total script time: 0.65 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Jul 11, 2015
…Controls Remove `PDFViewerApplication.updateScaleControls` (issue 6158)
|
Really nice! Probably the last step is to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch we're getting very close to fixing #6158.
The only use-case for
PDFViewerApplication.updateScaleControlsis to try and avoid callingselectScaleOptionfrom thescalechangeevent handler in viewer.js.This will only happen when the user has manually changed the scale by using the
<select>dropdown, which means that in reality this is just a micro optimization. Furthermore,selectScaleOptionis only skipped for the "named" scale values (e.g.auto,page-actual,page-fit,page-width), thus further reducing the value of this code.Also, since we're updating the scale
<select>dropdown from an event handler, we're currently depending on the event being dispatched (and handled) completely before the nextscalechangeevent. Relying on the execution order of the code in this way, even though it currently works, seems unfortunate since it could potentially cause the internal scale value and the UI from getting out of sync.