Issue a warning instead of an error for long Names #6193
Conversation
The PDF specification (cited below) specifies a maximum length of a name in bytes as a minimal architectural limit. This means that PDF *writers* should not create names that exceed 127 bytes. It does not forbid PDF *readers* to accept such names though. These names are only used internally to link PDF objects to other objects. For these use cases, the lengths of the names do not really matter. Hence I have changed the implementation to not treat long names as errors, but warnings. > (7.3.5) The length of a name shall be subject to an implementation > limit; see Annex C. > > (Annex C.2) Table C.1 describes the minimum architectural limits that > should be accommodated by conforming readers running on 32-bit > machines. Because conforming readers may be subject to these limits, > conforming writers producing PDF files should remain within them. > > (Table C.1) name 127 "Maximum length of a name, in bytes." http://adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/40766676f713377/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/c76b4bd05d69460/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/c76b4bd05d69460/output.txt Total script time: 18.58 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/40766676f713377/output.txt Total script time: 18.97 mins
|
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/903338cafabeeb0/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/903338cafabeeb0/output.txt Total script time: 0.67 mins Published |
Issue a warning instead of an error for long Names
|
Nice, thanks! |
|
Thanks so much @timvandermeij, @Rob--W @Snuffleupagus and anyone else who took a second on the issue! Love the enthusiasm with which this was addressed. Great example of maintaining a great tool. |
Fixes #6151
The PDF specification (cited below) specifies a maximum length of a name in bytes as a minimal architectural limit. This means that PDF writers should not create names that exceed 127 bytes.
It does not forbid PDF readers to accept such names though. These names are only used internally to link PDF objects to other objects. For these use cases, the lengths of the names do not really matter. Hence I have changed the implementation to not treat long names as errors, but warnings.