Implements paintFormXObject in svg.js #5198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurydelendik
added a commit
that referenced
this pull request
Aug 15, 2014
Implements paintFormXObject in svg.js
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partly addresses #4985 and makes the image on page 6 of the Tracemonkey paper render properly.
The addition of
this.cgrp.appendChild(this.tgrp);is necessary to make the text elements appear after clipping inpaintFormXObjectBegin, which actually resolves a bug in the current master and makes the text in the images on pages 10, 11 and 13 also render now.The only issue left is the image on page 2 of the Tracemonkey paper, but it doesn't appear to be caused by this PR, but it rather appears to be another bug in the current master. @pramodhkp Could you take a look what's causing the issue on page 2? If it's indeed a bug in the current master, it can be fixed in a separate PR.