Fix failing integration test on Windows with Chrome #18860

calixteman · 2024-10-06T14:29:06Z

It fixes #18775.

calixteman · 2024-10-06T14:29:17Z

/botio integrationtest

moz-tools-bot · 2024-10-06T14:29:20Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/00b997dc5c2d57e/output.txt

moz-tools-bot · 2024-10-06T14:29:21Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/cdbd7908806881b/output.txt

moz-tools-bot · 2024-10-06T14:39:09Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/00b997dc5c2d57e/output.txt

Total script time: 9.80 mins

Integration Tests: Passed

moz-tools-bot · 2024-10-06T14:48:57Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/cdbd7908806881b/output.txt

Total script time: 19.60 mins

Integration Tests: FAILED

calixteman · 2024-10-06T14:57:27Z

/botio integrationtest

moz-tools-bot · 2024-10-06T14:57:29Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ec07e899a32bca4/output.txt

moz-tools-bot · 2024-10-06T14:57:29Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5ed9c8e29197288/output.txt

moz-tools-bot · 2024-10-06T15:07:11Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/ec07e899a32bca4/output.txt

Total script time: 9.68 mins

Integration Tests: Passed

moz-tools-bot · 2024-10-06T15:17:23Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/5ed9c8e29197288/output.txt

Total script time: 19.89 mins

Integration Tests: FAILED

calixteman · 2024-10-06T15:25:57Z

/botio integrationtest

moz-tools-bot · 2024-10-06T15:25:59Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3158c6694f86b07/output.txt

moz-tools-bot · 2024-10-06T15:25:59Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/76636f2dc0bf9d6/output.txt

moz-tools-bot · 2024-10-06T15:35:40Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/76636f2dc0bf9d6/output.txt

Total script time: 9.68 mins

Integration Tests: Passed

moz-tools-bot · 2024-10-06T15:46:06Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/3158c6694f86b07/output.txt

Total script time: 20.11 mins

Integration Tests: FAILED

calixteman · 2024-10-06T16:01:10Z

/botio-windows integrationtest

moz-tools-bot · 2024-10-06T16:01:13Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b2c2aa87f913827/output.txt

moz-tools-bot · 2024-10-06T16:05:00Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/b2c2aa87f913827/output.txt

Total script time: 3.77 mins

Integration Tests: Passed

calixteman · 2024-10-06T16:08:35Z

/botio-windows integrationtest

moz-tools-bot · 2024-10-06T16:08:37Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/db45f8c6591100e/output.txt

moz-tools-bot · 2024-10-06T16:29:26Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/db45f8c6591100e/output.txt

Total script time: 20.81 mins

Integration Tests: FAILED

calixteman · 2024-10-06T16:54:02Z

/botio integrationtest

moz-tools-bot · 2024-10-06T16:54:05Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1c357fb457d8fb2/output.txt

moz-tools-bot · 2024-10-06T16:54:05Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/91d5aa039bf288d/output.txt

calixteman · 2024-10-06T17:55:41Z

/botio integrationtest

moz-tools-bot · 2024-10-06T17:55:43Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/85dad2660bf7ee8/output.txt

moz-tools-bot · 2024-10-06T17:55:43Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a4b700834c0b016/output.txt

moz-tools-bot · 2024-10-06T18:05:26Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a4b700834c0b016/output.txt

Total script time: 9.71 mins

Integration Tests: Passed

moz-tools-bot · 2024-10-06T18:16:50Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/85dad2660bf7ee8/output.txt

Total script time: 21.12 mins

Integration Tests: FAILED

calixteman · 2024-10-06T18:46:48Z

/botio integrationtest

moz-tools-bot · 2024-10-06T18:46:50Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/23e6bce3ea03d35/output.txt

moz-tools-bot · 2024-10-06T18:46:50Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/33fdf3a278a4eb0/output.txt

moz-tools-bot · 2024-10-06T18:56:34Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/33fdf3a278a4eb0/output.txt

Total script time: 9.71 mins

Integration Tests: Passed

moz-tools-bot · 2024-10-06T19:07:17Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/23e6bce3ea03d35/output.txt

Total script time: 20.43 mins

Integration Tests: FAILED

calixteman · 2024-10-06T19:13:38Z

@timvandermeij The issue is fixed now: the root cause was about not having integer coordinates. I don't know if some was selected but for sure the selectionchange event wasn't triggered because of that.
So thank you for the tip (about rounding the coordinates) 😃

timvandermeij

I'm happy that we have a solution in the works for this test now. Mostly looks good to me, with a few questions and s/Windws/Windows in the commit message.

test/integration/highlight_editor_spec.mjs

calixteman · 2024-10-06T20:22:41Z

/botio integrationtest

moz-tools-bot · 2024-10-06T20:22:44Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/78239c26e58b0f3/output.txt

moz-tools-bot · 2024-10-06T20:22:44Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fa6441345a50bbe/output.txt

moz-tools-bot · 2024-10-06T20:32:28Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/fa6441345a50bbe/output.txt

Total script time: 9.72 mins

Integration Tests: FAILED

moz-tools-bot · 2024-10-06T20:42:43Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/78239c26e58b0f3/output.txt

Total script time: 19.96 mins

Integration Tests: FAILED

It fixes mozilla#18775.

calixteman · 2024-10-06T20:47:59Z

/botio integrationtest

moz-tools-bot · 2024-10-06T20:48:01Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/72207c8f55103c7/output.txt

moz-tools-bot · 2024-10-06T20:48:01Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/394c96f2c8d83ab/output.txt

moz-tools-bot · 2024-10-06T20:57:43Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/72207c8f55103c7/output.txt

Total script time: 9.69 mins

Integration Tests: Passed

moz-tools-bot · 2024-10-06T21:07:40Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/394c96f2c8d83ab/output.txt

Total script time: 19.64 mins

Integration Tests: Passed

timvandermeij

r=me, with the comments below addressed. Thank you for doing this!

timvandermeij · 2024-10-08T19:07:42Z

test/integration/highlight_editor_spec.mjs

@@ -1811,6 +1815,9 @@ describe("Highlight Editor", () => {
          }


Shouldn't we also use Math.round(y) in the line above since y is divided in the loop? That'd also make it equal to the test below.

timvandermeij · 2024-10-08T19:08:03Z

test/integration/highlight_editor_spec.mjs

          let y = rect.y + rect.height / 2;
          await page.mouse.click(x, y, { count: 3, delay: 100 });
          await page.waitForSelector(editorSelector);
          await waitForSerialized(page, 1);
          await page.keyboard.press("Escape");
          await page.waitForSelector(`${editorSelector}:not(.selectedEditor)`);

+          const clickHandle = await waitForPointerUp(page);
+          y = rect.y - 3 * rect.height;
+          await page.mouse.move(x, Math.round(y));


To increase similarity with the other test updated above in this PR I suggest we move the Math.round call for y here to line 1852 where the actual division happens.

timvandermeij · 2024-10-08T19:09:55Z

test/integration/text_layer_spec.mjs

@@ -39,15 +39,21 @@ describe("Text layer", () => {
    }

    function middlePosition(rect) {
-      return { x: rect.x + rect.width / 2, y: rect.y + rect.height / 2 };
+      return {


I checked out this patch locally, but unfortunately these changes aren't enough to fix #18774. I'd therefore suggest we remove the changes to this file from this PR and work on this test in a separate PR, to speed up landing this PR first because the highlight test is more important as it fails on the bots.

(I initially thought both issues shared the same root cause after playing around with rounding in getSpanRect, but I should probably have thought about that better before suggesting we try to fix that one too in this PR; sorry for that.)

calixteman force-pushed the issue18775 branch from 1db75ca to d6fee54 Compare October 6, 2024 14:56

calixteman force-pushed the issue18775 branch from d6fee54 to ebdebe7 Compare October 6, 2024 15:25

calixteman force-pushed the issue18775 branch from ebdebe7 to dd752ff Compare October 6, 2024 16:00

calixteman force-pushed the issue18775 branch from dd752ff to 07594b0 Compare October 6, 2024 16:08

timvandermeij added the test label Oct 6, 2024

calixteman force-pushed the issue18775 branch from 07594b0 to 4c2a96e Compare October 6, 2024 16:53

calixteman force-pushed the issue18775 branch from f4a80bc to 4ec0e9b Compare October 6, 2024 17:55

calixteman requested a review from timvandermeij October 6, 2024 19:14

timvandermeij reviewed Oct 6, 2024

View reviewed changes

test/integration/highlight_editor_spec.mjs Show resolved Hide resolved

test/integration/highlight_editor_spec.mjs Show resolved Hide resolved

timvandermeij mentioned this pull request Oct 6, 2024

Fix typing logic in the scripting integration tests #18862

Merged

calixteman force-pushed the issue18775 branch from 4ec0e9b to 2d9bfd1 Compare October 6, 2024 20:21

Fix failing integration test on Windws with Chrome

15c930d

It fixes mozilla#18775.

calixteman force-pushed the issue18775 branch from 2d9bfd1 to 15c930d Compare October 6, 2024 20:45

timvandermeij approved these changes Oct 8, 2024

View reviewed changes

Snuffleupagus changed the title ~~Fix failing integration test on Windws with Chrome~~ Fix failing integration test on Windows with Chrome Oct 10, 2024

Fix failing integration test on Windows with Chrome #18860

Are you sure you want to change the base?

Fix failing integration test on Windows with Chrome #18860

Conversation

calixteman commented Oct 6, 2024

calixteman commented Oct 6, 2024

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Received

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Success

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Failed

calixteman commented Oct 6, 2024

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Received

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Success

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Failed

calixteman commented Oct 6, 2024

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Received

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Success

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Failed

calixteman commented Oct 6, 2024

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Received

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Success

calixteman commented Oct 6, 2024

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Received

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Failed

calixteman commented Oct 6, 2024

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Received

calixteman commented Oct 6, 2024

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Received

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Linux m4)

Success

moz-tools-bot commented Oct 6, 2024

From: Bot.io (Windows)

Failed

calixteman commented Oct 6, 2024

moz-tools-bot commented Oct 6, 2024

calixteman commented Oct 6, 2024 •

edited

Loading

timvandermeij left a comment •

edited

Loading

timvandermeij Oct 8, 2024 •

edited

Loading

timvandermeij Oct 8, 2024 •

edited

Loading