Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write the display flags in F entry when saving an annotation (issue 18072) #18824

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Write the display flags in F entry when saving an annotation (issue 18072) #18824

merged 1 commit into from
Oct 2, 2024
+120 −11

Conversation

calixteman
Copy link
Contributor

Fixes #18072.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/eb0c701ff8170b4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/44ec5db207e0447/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/44ec5db207e0447/output.txt

Total script time: 22.66 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 19
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/44ec5db207e0447/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/eb0c701ff8170b4/output.txt

Total script time: 31.71 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 5

Image differences available at: http://54.193.163.58:8877/eb0c701ff8170b4/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d7e56d9175be656/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/106f8994b257310/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/106f8994b257310/output.txt

Total script time: 10.64 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/d7e56d9175be656/output.txt

Total script time: 21.02 mins

  • Integration Tests: FAILED

Snuffleupagus
Snuffleupagus approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with a small suggested simplification; thank you.

src/core/annotation.js Show resolved Hide resolved
src/core/annotation.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5e6e7c3a9150063/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d982f0de60e5e0d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/d982f0de60e5e0d/output.txt

Total script time: 31.50 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 18
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/d982f0de60e5e0d/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/5e6e7c3a9150063/output.txt

Total script time: 46.86 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 50

Image differences available at: http://54.193.163.58:8877/5e6e7c3a9150063/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

I cannot reproduce the windows issue locally but I wonder if it could be related to the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1919906.

@calixteman
Copy link
Contributor Author

My guess about the potential culprit was correct and I filed a bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1922063

@Snuffleupagus, is it ok for you to make references even with this bug ?

@calixteman
Copy link
Contributor Author

I changed the firefox binary on the windows bot in order to just the penultimate one.
/botio-windows test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/01bf095915a3b9b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/01bf095915a3b9b/output.txt

Total script time: 60.00 mins

@calixteman
Copy link
Contributor Author

/botio-windows test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/71f1d392fe670a7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/71f1d392fe670a7/output.txt

Total script time: 2.24 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/71f1d392fe670a7/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio-windows test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1bb327e91eba834/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/1bb327e91eba834/output.txt

Total script time: 46.90 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 50

Image differences available at: http://54.193.163.58:8877/1bb327e91eba834/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator

is it ok for you to make references even with this bug ?

I don't think we have much choice, we'll "have" to do that for now, since otherwise testing other PRs become difficult if there's loads of unrelated failures.

@calixteman calixteman merged commit 0308b80 into mozilla:master Oct 2, 2024
8 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/43d795831d2d5a1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/38448d9a397d8fa/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/38448d9a397d8fa/output.txt

Total script time: 20.50 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/43d795831d2d5a1/output.txt

Total script time: 25.74 mins

  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
annotations form-acroform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fields not rendered after saving and opening Dutch tax form
3 participants
@calixteman @moz-tools-bot @Snuffleupagus