Limit base-class initialization checks to development and TESTING modes #18598
Conversation
We have a number of base-classes that are only intended to be extended, but never to be used directly. To help enforce this during development these base-class constructors will check for direct usage, however that code is obviously not needed in the actual builds. *Note:* This patch reduces the size of the `gulp mozcentral` output by `~2.7` kilo-bytes, which isn't a lot but still cannot hurt.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b28f0bda69496ca/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0f1ba64a0b5439b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0f1ba64a0b5439b/output.txt Total script time: 29.95 mins
Image differences available at: http://54.241.84.105:8877/0f1ba64a0b5439b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b28f0bda69496ca/output.txt Total script time: 45.36 mins
Image differences available at: http://54.193.163.58:8877/b28f0bda69496ca/reftest-analyzer.html#web=eq.log |
|
Thanks! (The broken annotation icons are not related to this patch since I've noticed them in other test runs as well; I'll make a follow-up issue for that.) |
We have a number of base-classes that are only intended to be extended, but never to be used directly. To help enforce this during development these base-class constructors will check for direct usage, however that code is obviously not needed in the actual builds.
Note: This patch reduces the size of the
gulp mozcentraloutput by~2.7kilo-bytes, which isn't a lot but still cannot hurt.