Use the waitForEvent helper function in the text layer integration tests
#18555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests The `waitForClick` helper function is functionality-wise mostly a reduced copy of the more generic `waitForEvent` helper function that we use for other integration tests, so we can safely replace it to reduce the amount of code. Moreover, the `waitForClick` code is prone to intermittent failures given recent assertion failures we have seen on the bots (one of them is linked in mozilla#18396) while `waitForEvent` has recently been fixed to avoid intermittent failures, so usiong it should also get rid of the flakiness for these integration tests.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7eb280a10c83d87/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/f44a0df18d03a54/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7eb280a10c83d87/output.txt Total script time: 8.70 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f44a0df18d03a54/output.txt Total script time: 18.18 mins
|
nicolo-ribaudo
approved these changes
Aug 4, 2024
|
@nicolo-ribaudo No worries; I also didn't catch this during review, and such intermittent issues unfortunately often only tend to show up after a number of runs, and on the slower bot which makes it hard to reproduce locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
waitForClickhelper function is functionality-wise mostly a reduced copy of the more genericwaitForEventhelper function that we use for other integration tests, so we can safely replace it to reduce the amount of code.Moreover, the
waitForClickcode is prone to intermittent failures given recent assertion failures we have seen on the bots (one of them is linked in #18396) whilewaitForEventhas recently been fixed to avoid intermittent failures, so usiong it should also get rid of the flakiness for these integration tests.Fixes a part of #18396.