Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vertical variant of a char when it's in a missing vertical font (bug 1905623) #18369

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Use vertical variant of a char when it's in a missing vertical font (bug 1905623) #18369

merged 1 commit into from
Jul 4, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1a24e479d061495/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fc78ad56a1a8b11/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/1a24e479d061495/output.txt

Total script time: 37.97 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 27
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/1a24e479d061495/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/fc78ad56a1a8b11/output.txt

Total script time: 53.86 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 10

Image differences available at: http://54.193.163.58:8877/fc78ad56a1a8b11/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij mentioned this pull request Jul 3, 2024
Closed
@Snuffleupagus
Copy link
Collaborator

The test results look like you forgot to run browsertests and makeref in PR #18134 :-P

Snuffleupagus
Snuffleupagus requested changes Jul 3, 2024
View reviewed changes
src/core/core_utils.js Outdated Show resolved Hide resolved
@Snuffleupagus
Copy link
Collaborator

Does this patch also fix bug 1695816 and issue 12350, since those look similar?

@calixteman
Copy link
Contributor Author

Does this patch also fix bug 1695816 and issue 12350, since those look similar?

Yes it fixes bug 1695816 but not the gh issue.
In issue 12350, it's different because the font is horizontal.
So as pointed out in #12350 (comment), Chrome or Acrobat are probably inferring the verticality from the content stream.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e9971294f4c91e7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/32a0a012bc9b6a3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/32a0a012bc9b6a3/output.txt

Total script time: 29.08 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 18
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/32a0a012bc9b6a3/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e9971294f4c91e7/output.txt

Total script time: 44.15 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 6

Image differences available at: http://54.193.163.58:8877/e9971294f4c91e7/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

@calixteman calixteman merged commit 617f513 into mozilla:master Jul 4, 2024
9 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/200492879e9e54c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5a46675c2bf4aa2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/200492879e9e54c/output.txt

Total script time: 20.00 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/5a46675c2bf4aa2/output.txt

Total script time: 24.82 mins

  • Make references: Passed
  • Check references: Passed

@Redv123
Copy link

Redv123 commented Jul 4, 2024 •
edited
Loading

There are still some punctuation marks that have not been converted to vertical.
10
image

@calixteman
Copy link
Contributor Author

@Redv123, this a PR so it isn't the right place to talk about issues.
So please file a new issue and attach the pdf: it's likely a dup of #12350 but without having the pdf it's impossible to guess.

@npanchal108 npanchal108 mentioned this pull request Aug 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
font-conversion non-standard-fonts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@calixteman @moz-tools-bot @Snuffleupagus @Redv123 @timvandermeij