Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pause l10n (i.e. disconnect the mutation observer in fluent) when closing the viewer #18280

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Pause l10n (i.e. disconnect the mutation observer in fluent) when closing the viewer #18280

merged 1 commit into from
Jun 18, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman linked an issue Jun 18, 2024 that may be closed by this pull request
Fix dumpio: true logs about translateMutations #18279
Closed
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/01d895bb9c0b946/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 2

Live output at: http://54.193.163.58:8877/3c3c6211ef7fa46/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/01d895bb9c0b946/output.txt

Total script time: 7.97 mins

  • Integration Tests: Passed

Snuffleupagus
Snuffleupagus reviewed Jun 18, 2024
View reviewed changes
web/app.js Outdated Show resolved Hide resolved
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/3c3c6211ef7fa46/output.txt

Total script time: 19.90 mins

  • Integration Tests: FAILED

@timvandermeij
Copy link
Contributor

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ffbd3f5a771c53b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/fc994cb0c4674a5/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/ffbd3f5a771c53b/output.txt

Total script time: 7.72 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/fc994cb0c4674a5/output.txt

Total script time: 17.95 mins

  • Integration Tests: FAILED

timvandermeij
timvandermeij approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me; thanks! The logs are looking better with every patch being made; really nice.

@timvandermeij timvandermeij merged commit 4b5d5a5 into mozilla:master Jun 18, 2024
7 checks passed
@Snuffleupagus Snuffleupagus mentioned this pull request Jun 22, 2024
Merged
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus left review comments

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix dumpio: true logs about translateMutations
4 participants
@calixteman @moz-tools-bot @timvandermeij @Snuffleupagus