Improve date parsing in the js sandbox #18234
Conversation
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6bf58f4bc1bebc5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/597197ad37d2556/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6bf58f4bc1bebc5/output.txt Total script time: 2.54 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/597197ad37d2556/output.txt Total script time: 11.46 mins
|
calixteman
force-pushed
the
improve_date_parsing
branch
from
7ada0f7
to
ba1b5e8
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8b3577c851220c9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/84fd5daec47de22/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8b3577c851220c9/output.txt Total script time: 2.48 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/84fd5daec47de22/output.txt Total script time: 10.74 mins
|
|
Out of curiosity, does this fix a particular issue or bug (and if so, could you link it in the commit message), or is it just something you happen to notice/stumble upon in the specification (and if so, could you point to that since it helps me to review this patch)? |
Yep, after this comment: |
If for example dd:mm is failing we just try with d:m which is equivalent
to the regex /d{1,2}:m{1,2}/. This way it allows the user to forget the
0 for the first days/months.
calixteman
force-pushed
the
improve_date_parsing
branch
from
ba1b5e8
to
c14c3cf
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ef0a2664e2ff376/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/fe8f9cb5a95c6a1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ef0a2664e2ff376/output.txt Total script time: 2.52 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/fe8f9cb5a95c6a1/output.txt Total script time: 7.78 mins
|
|
Thank you for improving this! |
If for example dd:mm is failing we just try with d:m which is equivalent to the regex /d{1,2}:m{1,2}/.
This way it allows the user to forget the 0 for the first days/months.