Don't register a pending TextLayer until render is invoked (PR 18104 follow-up)
#18171
Conversation
Snuffleupagus
added
text-selection
release-blocker
Snuffleupagus
changed the title
TextLayer until ´render` is invoked (PR 18104 follow-up)TextLayer until render is invoked (PR 18104 follow-up)
…104 follow-up) After the re-factoring in PR 18104 there's now a *theoretical* risk that a pending `TextLayer` is never removed, which we can avoid by not registering it until `render` is invoked. Note that this doesn't affect the viewer or tests, but if a third-party user calls `new TextLayer(...)` without a following call of either the `render`- or `cancel`-method we'd block global clean-up without this patch.
Snuffleupagus
force-pushed
the
move-pendingTextLayers
branch
from
8fb19a7
to
f2e7eee
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5aff14008bf746c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a2ca55e415ef05e/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a2ca55e415ef05e/output.txt Total script time: 3.08 mins
Image differences available at: http://54.193.163.58:8877/a2ca55e415ef05e/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5aff14008bf746c/output.txt Total script time: 27.87 mins
Image differences available at: http://54.241.84.105:8877/5aff14008bf746c/reftest-analyzer.html#web=eq.log |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/8d1684a05e080be/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8d1684a05e080be/output.txt Total script time: 42.80 mins
Image differences available at: http://54.193.163.58:8877/8d1684a05e080be/reftest-analyzer.html#web=eq.log |
|
Thank you for spotting this! |
After the re-factoring in PR #18104 there's now a theoretical risk that a pending
TextLayeris never removed, which we can avoid by not registering it untilrenderis invoked.Note that this doesn't affect the viewer or tests, but if a third-party user calls
new TextLayer(...)without a following call of either therender- orcancel-method we'd block global clean-up without this patch.