Remove the obsolete needle dependency
#18107
Conversation
The `needle` dependency originally got introduced in mozilla#12024, almost four years ago, to be able to use pre-built binaries for the `canvas` dependency on macOS. However, nowadays the `needle` dependency isn't used by `canvas` anymore, or any other package we use for that matter, as shown by the empty NPM dependency tree: ``` $ npm ls needle pdf.js └── needle@3.3.1 ``` Investigation showed that the `canvas` package depends on the `node-pre-gyp` package which in turn depended on `needle` (see Automattic/node-canvas#1110 (comment)), but in version 1.0.0 of `node-pre-gyp` from three years ago the `needle` dependency got dropped in favor of `node-fetch` (see https://github.com/mapbox/node-pre-gyp/blob/a74f5e367c0d71033620aa0112e7baf7f3515b9d/CHANGELOG.md?plain=1#L52). This explains why the NPM dependency tree is empty now and proves that we can safely get rid of this dependency now.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/51a0b0e9ddf7cc7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/51a0b0e9ddf7cc7/output.txt Total script time: 1.16 mins Published |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9511f4f835d90b1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/46f601332dca73f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9511f4f835d90b1/output.txt Total script time: 7.32 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/46f601332dca73f/output.txt Total script time: 19.37 mins
|
The
needledependency originally got introduced in #12024, almost four years ago, to be able to use pre-built binaries for thecanvasdependency on macOS. However, nowadays theneedledependency isn't used bycanvasanymore, or any other package we use for that matter, as shown by the empty NPM dependency tree:Investigation showed that the
canvaspackage depends on thenode-pre-gyppackage which in turn depended onneedle(see Automattic/node-canvas#1110 (comment)), but in version 1.0.0 ofnode-pre-gypfrom three years ago theneedledependency got dropped in favor ofnode-fetch(see https://github.com/mapbox/node-pre-gyp/blob/a74f5e367c0d71033620aa0112e7baf7f3515b9d/CHANGELOG.md?plain=1#L52). This explains why the NPM dependency tree is empty now and proves that we can safely get rid of this dependency now.