Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to insert several annotations under the same parent in the structure tree #17986

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Allow to insert several annotations under the same parent in the structure tree #17986

merged 1 commit into from
Apr 24, 2024

Conversation

calixteman
Copy link
Contributor

While testing stamp insertion with the added pdf, I noticed that the tags using a MCID weren't considered when trying to attach an annotation to it.

@calixteman
Copy link
Contributor Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1f7aabf1d432f3d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/59f6427a7a94e08/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/59f6427a7a94e08/output.txt

Total script time: 2.53 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/1f7aabf1d432f3d/output.txt

Total script time: 9.63 mins

  • Unit Tests: Passed

@calixteman
Copy link
Contributor Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1ced57d3031966d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2c1cc61e50c6cfa/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1ced57d3031966d/output.txt

Total script time: 2.51 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/2c1cc61e50c6cfa/output.txt

Total script time: 10.56 mins

  • Unit Tests: Passed

Snuffleupagus
Snuffleupagus approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with comments; thank you!

test/unit/api_spec.js Show resolved Hide resolved
test/unit/primitives_spec.js Outdated Show resolved Hide resolved
src/core/struct_tree.js Outdated Show resolved Hide resolved
@calixteman
Allow to insert several annotations under the same parent in the stru…
45fa867 
…cture tree

While testing stamp insertion with the added pdf, I noticed that the tags using a MCID
weren't considered when trying to attach an annotation to it.
@calixteman
Copy link
Contributor Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ea8e1fd1e8498f3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4f03ecacb109360/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/ea8e1fd1e8498f3/output.txt

Total script time: 2.53 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/4f03ecacb109360/output.txt

Total script time: 10.05 mins

  • Unit Tests: Passed

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2253fd8578d46f8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0bd472b48558bff/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/0bd472b48558bff/output.txt

Total script time: 2.78 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/0bd472b48558bff/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio-windows test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2d398d15ab94bef/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/2d398d15ab94bef/output.txt

Total script time: 6.51 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/2d398d15ab94bef/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio-windows test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9dab648bdbf2803/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/2253fd8578d46f8/output.txt

Total script time: 27.18 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 23
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/2253fd8578d46f8/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/9dab648bdbf2803/output.txt

Total script time: 41.38 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 3

Image differences available at: http://54.193.163.58:8877/9dab648bdbf2803/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit d1f494d into mozilla:master Apr 24, 2024
9 checks passed
@calixteman calixteman deleted the fix_struct_tree branch April 24, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij left review comments

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
accessibility annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @moz-tools-bot @timvandermeij @Snuffleupagus