Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate explicit destinations on the worker-thread to prevent DataCloneError (issue 17981) #17984

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Validate explicit destinations on the worker-thread to prevent DataCloneError (issue 17981) #17984

merged 1 commit into from
Apr 24, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

Note: This borrows a helper function from the viewer, however the code cannot be directly shared since the worker-thread has access to various primitives.

@Snuffleupagus Snuffleupagus linked an issue Apr 22, 2024 that may be closed by this pull request
Unhandled Rejection for getAnnotations #17981
Closed
@Snuffleupagus Snuffleupagus marked this pull request as draft April 22, 2024 13:58
@mozilla mozilla deleted a comment from moz-tools-bot Apr 22, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Apr 22, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Apr 22, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Apr 22, 2024
@Snuffleupagus Snuffleupagus marked this pull request as ready for review April 22, 2024 14:17
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9fbaa8d93fb1ae7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/ddb555151f96cd7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/9fbaa8d93fb1ae7/output.txt

Total script time: 27.22 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 18
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/9fbaa8d93fb1ae7/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/ddb555151f96cd7/output.txt

Total script time: 41.70 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 3

Image differences available at: http://54.193.163.58:8877/ddb555151f96cd7/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Validate explicit destinations on the worker-thread to prevent `DataC…
7206d0a 
…loneError` (issue 17981)

*Note:* This borrows a helper function from the viewer, however the code cannot be directly shared since the worker-thread has access to various primitives.
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/229d807a2978e94/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bc6bd05445fc79c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/229d807a2978e94/output.txt

Total script time: 2.54 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/bc6bd05445fc79c/output.txt

Total script time: 11.44 mins

  • Unit Tests: Passed

timvandermeij
timvandermeij approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment below answered/addressed. Thanks!

web/pdf_link_service.js Show resolved Hide resolved
@timvandermeij timvandermeij merged commit 885dd72 into mozilla:master Apr 24, 2024
9 checks passed
@Snuffleupagus Snuffleupagus deleted the issue-17981 branch April 24, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhandled Rejection for getAnnotations
3 participants
@Snuffleupagus @moz-tools-bot @timvandermeij