Remove all waitForTimeout usage from the annotation integration tests
#17969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/61a3b3336ed5456/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/14e6fef0ac4728e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/61a3b3336ed5456/output.txt Total script time: 9.97 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/14e6fef0ac4728e/output.txt Total script time: 17.37 mins
|
|
(I'm deferring to @calixteman on this.) |
This commit replaces all `waitForTimeout` occurrences with the appropriate `waitForFunction` calls. Note that in some places they were already present, so in those cases we could simply remove the `waitForTimeout` call altogether.
timvandermeij
force-pushed
the
integration-tests-timeout-annotations
branch
from
53769f9
to
10641d5
Compare
timvandermeij
changed the title
waitForTimeout usage from the annotation integration testswaitForTimeout usage from the annotation integration tests
|
I have only rebased the patch and updated the commit message since the last run; no other (functional) changes have been made. |
calixteman
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces all
waitForTimeoutoccurrences with the appropriatewaitForFunctioncalls. Note that in some places they were already present, so in those cases we could simply remove thewaitForTimeoutcall altogether.Fixes a part of #17656.