Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize the ExternalServices-instance lazily in the viewer (PR 17588 follow-up) #17604

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Initialize the ExternalServices-instance lazily in the viewer (PR 17588 follow-up) #17604

merged 1 commit into from
Jan 31, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

No description provided.

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Jan 31, 2024 •
edited
Loading

Strangely enough this doesn't reproduce in the GENERIC viewer.

Unfortunately I've not (yet) had time to test this in a local mozilla-central build, but hopefully delaying the initialization is enough to fix the failures in https://bugzilla.mozilla.org/show_bug.cgi?id=1877789#c1

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Jan 31, 2024 •
edited
Loading

I've successfully run ./mach test toolkit/components/pdfjs/ locally with this patch applied.

calixteman
calixteman approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test ?
That said, it looks good to me, thank you.
I'll update the m-c patch tomorrow.

@Snuffleupagus
Copy link
Collaborator Author

Is it possible to add a test ?

Given that I cannot reproduce this in the GENERIC viewer, I unfortunately don't have any ideas how we could test this here.

(The underlying issue seems to be somehow related to the include-order in the built viewer, and that's always subject to change given that Webpack controls it.)

@Snuffleupagus Snuffleupagus merged commit eb5c1d4 into mozilla:master Jan 31, 2024
7 checks passed
@Snuffleupagus Snuffleupagus deleted the externalServices-lazy-init branch January 31, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
firefox-specific viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Snuffleupagus @calixteman