Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Add the possibility to change the thickness of a free highlight (bug 1876096) #17568

Merged

Conversation

calixteman
Copy link
Contributor

No description provided.

l10n/en-US/viewer.ftl Outdated Show resolved Hide resolved
l10n/en-US/viewer.ftl Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the editor_free_highlight_thickness branch from 1acfd6c to 8691355 Compare January 23, 2024 20:58
src/display/editor/editor.js Outdated Show resolved Hide resolved
src/display/editor/highlight.js Outdated Show resolved Hide resolved
src/display/editor/highlight.js Outdated Show resolved Hide resolved
src/display/editor/highlight.js Outdated Show resolved Hide resolved
web/viewer.html Outdated Show resolved Hide resolved
src/display/editor/highlight.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the editor_free_highlight_thickness branch 3 times, most recently from 9f9c7ac to 5ce7f40 Compare January 24, 2024 18:16
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests; thank you!

@calixteman calixteman force-pushed the editor_free_highlight_thickness branch from 5ce7f40 to 2b8ecf5 Compare January 24, 2024 21:04
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ea76e4220dd80fd/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a3320ea473f0642/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/ea76e4220dd80fd/output.txt

Total script time: 6.05 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/a3320ea473f0642/output.txt

Total script time: 16.78 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit a5d4660 into mozilla:master Jan 24, 2024
10 checks passed
@calixteman calixteman deleted the editor_free_highlight_thickness branch January 24, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants