[Editor] Add the ability to make a free highlight (i.e. without having to select some text) (bug 1856218) #17506
Conversation
calixteman
force-pushed
the
editor_free_highlight
branch
from
c9abf3a
to
8419652
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/bc25202cb0e5dca/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/bc25202cb0e5dca/output.txt Total script time: 1.60 mins Published |
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
calixteman
force-pushed
the
editor_free_highlight
branch
2 times, most recently
from
47e57d4
to
6eaa45f
Compare
|
Should this new highlight-mode perhaps use a "custom" cursor (comparing with e.g. the Ink-editor), rather than the default one? |
The UI/UX team is already aware about this "problem" and should have a solution for it in the next days. |
calixteman
force-pushed
the
editor_free_highlight
branch
8 times, most recently
from
43ccff0
to
5c2f4f5
Compare
There was a problem hiding this comment.
Based on testing the preview in #17506 (comment) I've noticed a couple of issues.
-
- Enable free-highlighting and begin drawing.
- While still holding the left mouse button pressed, click once on the right mouse button to bring up the context menu.
- Note that you can still keep drawing, by moving the mouse, despite the context menu being open.
-
- Enable free-highlighting and begin drawing.
- While still holding the left mouse button pressed, click once on the right mouse button to bring up the context menu.
- Release the left mouse button, and then left click again.
- Editing doesn't stop properly, with the following Error being thrown:
Uncaught TypeError: can't access property "isEmpty", this._freeHighlight is null.
-
- Enable free-highlighting and begin drawing.
- Draw an irregular shape, and once done note that the
editToolbarmay end up in the "middle" of the highlight. (All other editors have the toolbar placed below.)
calixteman
force-pushed
the
editor_free_highlight
branch
from
5c2f4f5
to
f80f10c
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2969d19ba9be0ff/output.txt |
calixteman
force-pushed
the
editor_free_highlight
branch
from
f80f10c
to
93b64b0
Compare
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2969d19ba9be0ff/output.txt Total script time: 1.47 mins Published |
…g to select some text) (bug 1856218) The free highlighting is enabled when the mouse pointer isn't on some text. Then we draw a shape with smoothed borders corresponding to the movement of the mouse. Printing/saving and changing the thickness will come later.
calixteman
force-pushed
the
editor_free_highlight
branch
from
93b64b0
to
8fbfef0
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f83471f4f3b750d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cc52a8d705d8e64/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f83471f4f3b750d/output.txt Total script time: 24.93 mins
Image differences available at: http://54.241.84.105:8877/f83471f4f3b750d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/cc52a8d705d8e64/output.txt Total script time: 40.69 mins
Image differences available at: http://54.193.163.58:8877/cc52a8d705d8e64/reftest-analyzer.html#web=eq.log |
The free highlighting is enabled when the mouse pointer isn't on some text. Then we draw a shape with smoothed borders corresponding to the movement of the mouse.
Printing/saving and changing the thickness will come later.