Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Puppeteer to version 21.6.0 #17392

Closed
wants to merge 1 commit into from
Closed

Update Puppeteer to version 21.6.0 #17392

wants to merge 1 commit into from

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8f0f5406f31c18e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8cb6449a963beb3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/8f0f5406f31c18e/output.txt

Total script time: 60.00 mins

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/8cb6449a963beb3/output.txt

Total script time: 60.00 mins

@whimboo
Copy link
Contributor

whimboo commented Dec 8, 2023

The problem here is in puppeteer/puppeteer@f8c9469. The check for options.protocol in Puppeteer is failing and causing an important pref not to be set, because in test.mjs no protocol is set.

@calixteman just add protocol: 'cdp' and it will work.

@whimboo
Copy link
Contributor

whimboo commented Dec 8, 2023

I already pushed #17393 to see if that helps also for the bots.

@whimboo whimboo mentioned this pull request Dec 8, 2023
Merged
@calixteman calixteman closed this Dec 8, 2023
@calixteman calixteman deleted the update_puppeteer_21.6.0 branch December 8, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @whimboo