Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Avoid to have a color picker for highlighting twice in the main toolbar #17388

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

calixteman
Copy link
Contributor

@calixteman calixteman commented Dec 6, 2023

When opening a pdf from the secondary toolbar, a second color picker is added. So in order to avoid that, we just stop listening for annotationeditoruimanager in the toolbar.

…ain toolbar

When opening a pdf from the secondary toolbar, a second color picker is added.
So in order to avoid that, we just stop listening for annotationeditoruimanager
in the toolbar.
@calixteman calixteman changed the title [Editor] Avoid to have a color picker for highlighting twice in the m… [Editor] Avoid to have a color picker for highlighting twice in the main toolbar Dec 6, 2023
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

@calixteman calixteman merged commit f54cfe0 into mozilla:master Dec 6, 2023
7 checks passed
@calixteman calixteman deleted the no_double_color_picker branch December 6, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants