[Firefox] Restore opening of PDF attachments (issue 17353, bug 1867764) #17363
Conversation
Snuffleupagus
force-pushed
the
issue-17353
branch
2 times, most recently
from
2628694
to
d7271c4
Compare
Snuffleupagus
changed the title
This unfortunately broke in PR 17060, since I had completely forgotten about https://bugzilla.mozilla.org/show_bug.cgi?id=1632644#c5 when writing that patch. The easiest solution, while slightly unfortunate, seems to be to add a couple of non-standard hash parameters specifically for the PDF attachment use-case in the Firefox PDF Viewer. (Note that we cannot use "nameddest" here, since we also need to support the stringified destination-Array case.)
Snuffleupagus
force-pushed
the
issue-17353
branch
from
d7271c4
to
4c92ec9
Compare
|
@Snuffleupagus if this is a regression in Firefox, could you open a Bugzilla bug so we can track it? |
Is that still necessary even if I don't believe that this requires uplifting? Please note that this regression doesn't mean a total loss of functionality, a PDF attachment will just fallback to trigger the (browser) save-dialog rather than being opened in a new tab. |
|
It would be ideal in general to file a bug whenever there is a regression (even if severity will be low, S3 or S4), so we have more complete data we can use to identify changes that caused regressions and changes that didn't and for statistic purposes. |
Snuffleupagus
changed the title
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7c5bab7b84cf1f0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a8ce0a3826e6ab6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7c5bab7b84cf1f0/output.txt Total script time: 5.50 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/a8ce0a3826e6ab6/output.txt Total script time: 16.38 mins
|
This unfortunately broke in PR #17060, since I had completely forgotten about https://bugzilla.mozilla.org/show_bug.cgi?id=1632644#c5 when writing that patch.
The easiest solution, while slightly unfortunate, seems to be to add a couple of non-standard hash parameters specifically for the PDF attachment use-case in the Firefox PDF Viewer. (Note that we cannot use "nameddest" here, since we also need to support the stringified destination-Array case.)
Fixes #17353