Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "count" and not "clickCount" when calling page.mouse.click() #17358

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

whimboo
Copy link
Contributor

@whimboo whimboo commented Nov 30, 2023

The MouseClickOptions actually do not have a clickCount but a count field. As such a couple of freeform text editor tests are failing.

With this PR merged 4 out of 5 failing tests are passing.

@calixteman
Copy link
Contributor

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f965bf1061fc4bc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/aa0c2193e923b01/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/f965bf1061fc4bc/output.txt

Total script time: 5.47 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/aa0c2193e923b01/output.txt

Total script time: 7.22 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor

/botio-windows integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dbc27324209db13/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/dbc27324209db13/output.txt

Total script time: 14.04 mins

  • Integration Tests: Passed

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman calixteman merged commit d65dca7 into mozilla:master Nov 30, 2023
6 of 7 checks passed
@whimboo whimboo deleted the mouse_click_count branch November 30, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants