Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove language codes from text strings. #17331

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Remove language codes from text strings. #17331

merged 1 commit into from
Nov 25, 2023

Conversation

calixteman
Copy link
Contributor

And take care to have an even number of bytes with utf16 strings.

@calixteman
Copy link
Contributor Author

I found these bugs in:
https://bugs.chromium.org/p/pdfium/issues/detail?id=2101

Snuffleupagus
Snuffleupagus requested changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting find; leaving some questions.

src/shared/util.js Show resolved Hide resolved
src/shared/util.js Outdated Show resolved Hide resolved
src/shared/util.js Outdated Show resolved Hide resolved
Snuffleupagus
Snuffleupagus approved these changes Nov 25, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with two more comments; thank you!

src/shared/util.js Outdated Show resolved Hide resolved
src/shared/util.js Outdated Show resolved Hide resolved
@calixteman
Remove language codes from text strings.
eb5f610 
And take care to have an even number of bytes with utf16 strings.
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/59777912cb6b0d3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f14055379abfab8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/f14055379abfab8/output.txt

Total script time: 27.55 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 18
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/f14055379abfab8/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/59777912cb6b0d3/output.txt

Total script time: 35.26 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 28

Image differences available at: http://54.193.163.58:8877/59777912cb6b0d3/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 9d863f5 into mozilla:master Nov 25, 2023
9 checks passed
@calixteman calixteman deleted the lang_marker branch November 25, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @moz-tools-bot @Snuffleupagus @timvandermeij