Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Move the alt text button in the editor toolbar #17329

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[Editor] Move the alt text button in the editor toolbar #17329

merged 1 commit into from
Nov 28, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman marked this pull request as draft November 24, 2023 13:08
@calixteman
Copy link
Contributor Author

We must wait for an approval from UX it's why I keep it as a draft for the moment.

@calixteman
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7a19b8183ce5831/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/7a19b8183ce5831/output.txt

Total script time: 2.13 mins

Published

Snuffleupagus
Snuffleupagus reviewed Nov 24, 2023
View reviewed changes
src/display/editor/alt_text.js Outdated Show resolved Hide resolved
web/images/editor-toolbar-divider.svg Outdated Show resolved Hide resolved
@Snuffleupagus Snuffleupagus linked an issue Nov 24, 2023 that may be closed by this pull request
Alt-text and delete buttons may overlap #17298
Closed
@calixteman calixteman force-pushed the move_alt_text_button branch 3 times, most recently from eca36aa to 2d63e08 Compare November 24, 2023 15:53
@calixteman
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/da6f6be630faa8a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/da6f6be630faa8a/output.txt

Total script time: 1.40 mins

Published

@calixteman calixteman marked this pull request as ready for review November 27, 2023 16:19
@calixteman
Copy link
Contributor Author

Maybe the tooltip for the remove button will change, but for the rest, the patch can be reviewed.

Snuffleupagus
Snuffleupagus requested changes Nov 27, 2023
View reviewed changes
src/display/editor/alt_text.js Outdated Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
web/annotation_editor_layer_builder.css Outdated Show resolved Hide resolved
web/annotation_editor_layer_builder.css Outdated Show resolved Hide resolved
web/annotation_editor_layer_builder.css Outdated Show resolved Hide resolved
@calixteman calixteman requested a review from a team as a code owner November 28, 2023 12:43
flodolo
flodolo approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(with the obsolete string removed)

l10n/en-US/viewer.ftl Outdated Show resolved Hide resolved
flodolo
flodolo reviewed Nov 28, 2023
View reviewed changes
l10n/en-US/viewer.ftl Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the move_alt_text_button branch 2 times, most recently from 80a8f64 to ee870ff Compare November 28, 2023 14:32
Snuffleupagus
Snuffleupagus approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice since it not only fixes the button overlap, but it improves consistency in the editing-UI and does so with less code overall.

r=me, thank you!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d2cf4457740da60/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/58dc1ed3d357f08/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/58dc1ed3d357f08/output.txt

Total script time: 5.59 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/d2cf4457740da60/output.txt

Total script time: 14.16 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit f495239 into mozilla:master Nov 28, 2023
10 checks passed
@calixteman calixteman deleted the move_alt_text_button branch November 28, 2023 14:57
calixteman added a commit to calixteman/pdf.js that referenced this pull request Nov 29, 2023
@calixteman
[Editor] Fix subtype for telemetry data (follow-up of mozilla#17329)
05ca005 
Fix a test failure in m-c.
calixteman added a commit that referenced this pull request Nov 29, 2023
@calixteman
Merge pull request #17351 from calixteman/fix_mc_test
6a35e42 
[Editor] Fix subtype for telemetry data (follow-up of #17329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flodolo flodolo flodolo approved these changes

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alt-text and delete buttons may overlap
4 participants
@calixteman @moz-tools-bot @Snuffleupagus @flodolo