Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get the field name from its parent when it doesn't have one when collecting fields (bug 1864136) #17271

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Get the field name from its parent when it doesn't have one when collecting fields (bug 1864136) #17271

merged 1 commit into from
Nov 13, 2023

Conversation

calixteman
Copy link
Contributor

@calixteman calixteman commented Nov 13, 2023 •
edited
Loading

Some fields, somewhere under the Fields entry in Acroform, could have no name (in T)
but with a parent which has a name but which isn't somewhere under Fields.
As a side-effect, this patch prevents infinite loops because of potential cycles
under Fields.

Snuffleupagus
Snuffleupagus requested changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small typo in the commit message: doens't should be doesn't.

After addressing the comments, please run all tests.

src/core/document.js Outdated Show resolved Hide resolved
test/integration/test_utils.mjs Outdated Show resolved Hide resolved
test/integration/test_utils.mjs Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/32d859d93fa2b9e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7550afa2c84da55/output.txt

@calixteman calixteman changed the title Get the field name from its parent when it doens't have one when collecting fields (bug 1864136) Get the field name from its parent when it doesn't have one when collecting fields (bug 1864136) Nov 13, 2023
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/32d859d93fa2b9e/output.txt

Total script time: 6.58 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/7550afa2c84da55/output.txt

Total script time: 19.03 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

The test failures was because of some fields with no name but with a parent which has one, but the parent was visited during the Fields collection.

Snuffleupagus
Snuffleupagus approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with one comment; thank you!

src/core/document.js Outdated Show resolved Hide resolved
@calixteman
Get the field name from its parent when it doesn't have one when coll…
09b4fe6 
…ecting fields (bug 1864136)

Some fields, somewhere under the Fields entry in Acroform, could have no name (in T)
but with a parent which has a name but which isn't somewhere under Fields.
As a side-effect, this patch prevents infinite loops because of potential cycles
under Fields.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d24307623ba531b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/68401a519497981/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d24307623ba531b/output.txt

Total script time: 5.58 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/68401a519497981/output.txt

Total script time: 18.03 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 787d092 into mozilla:master Nov 13, 2023
7 checks passed
@calixteman calixteman deleted the maif branch November 13, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
form-acroform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus