Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete src/shared/{cffStandardStrings,fonts_utils}.js files #17120

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

timvandermeij
Copy link
Contributor

Those files only contain old debugging code that is not used/imported anywhere anymore, which is generating code scanning alerts. Moreover, they rely on globals/platform-specific code and don't import/export logic properly.

Fixes #17118.

Those files only contain old debugging code that is not used/imported
anywhere anymore, which is generating code scanning alerts. Moreover,
they rely on globals/platform-specific code and don't import/export
logic properly.
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5cf1f86703bba70/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/5cf1f86703bba70/output.txt

Total script time: 1.57 mins

Published

@timvandermeij timvandermeij merged commit d53e166 into mozilla:master Oct 14, 2023
3 checks passed
@timvandermeij timvandermeij deleted the code-scanning-alerts branch October 14, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix new code scanning alerts
3 participants