Enable the import/no-commonjs ESLint plugin rule
#17117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the amount of work put into removing `require`-calls from the code-base, let's ensure that new ones aren't accidentally added in the future. Note that we still have a couple of files where `require` is being used, in particular: - The Node.js examples, however those will be updated to use `import` in PR 17081. - The Webpack examples, and related support files, however I unfortunately don't know enough about Webpack to be able to update those. (Hopefully users of that code will help out here, once version `4` is released.) - The `statcmp`-tool, since *some* of those `require`-calls cannot be converted to `import` without other code changes (and that file is only used during benchmarking). Please find additional details at https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-commonjs.md
|
/botio lint |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/26b1e3e70f93b24/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c0c61994162eb49/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c0c61994162eb49/output.txt Total script time: 1.27 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/26b1e3e70f93b24/output.txt Total script time: 5.87 mins
|
timvandermeij
approved these changes
Oct 14, 2023
|
Good idea, and thanks for all the work to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the amount of work put into removing
require-calls from the code-base, let's ensure that new ones aren't accidentally added in the future.Note that we still have a couple of files where
requireis being used, in particular:importin PR Update theexamples/-folder to account for outputting of JavaScript modules (PR 17055 follow-up) #17081.4is released.)statcmp-tool, since some of thoserequire-calls cannot be converted toimportwithout other code changes (and that file is only used during benchmarking).Please find additional details at https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-commonjs.md