-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output JavaScript modules for the LIB
build-target (PR 17055 follow-up)
#17114
Conversation
d3a8e0a
to
d2a205f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
…-up) This *finally* allows us to mark the entire PDF.js library as a "module", which should thus conclude the (multi-year) effort to re-factor and improve how we import files/resources in the code-base. This also means that the `gulp ci-test` target, which is what's run in GitHub Actions, now uses JavaScript modules since that's supported in modern Node.js versions.
d2a205f
to
3824550
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/16df1e616c75a80/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/aaeb38384fbf6de/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/16df1e616c75a80/output.txt Total script time: 24.70 mins
Image differences available at: http://54.241.84.105:8877/16df1e616c75a80/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/aaeb38384fbf6de/output.txt Total script time: 37.05 mins
Image differences available at: http://54.193.163.58:8877/aaeb38384fbf6de/reftest-analyzer.html#web=eq.log |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4cb699214ebefe7/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/04fd3f6283662a1/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/04fd3f6283662a1/output.txt Total script time: 24.87 mins
Image differences available at: http://54.241.84.105:8877/04fd3f6283662a1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/4cb699214ebefe7/output.txt Total script time: 35.36 mins
Image differences available at: http://54.193.163.58:8877/4cb699214ebefe7/reftest-analyzer.html#web=eq.log |
This finally allows us to mark the entire PDF.js library as a "module", which should thus conclude the (multi-year) effort to re-factor and improve how we import files/resources in the code-base.
This also means that the
gulp ci-test
target, which is what's run in GitHub Actions, now uses JavaScript modules since that's supported in modern Node.js versions.Please note: This is depends on PR #17112 landing first, since otherwise the
integration
tests would break.