Activate the selector check for the autoprint integration test as soon as possible
#17090
Conversation
…oon as possible The Windows bot is usually slower than the Linux bot, and therefore text layer rendering is as well. However, the `autoprint` test awaited text layer rendering to complete before activating the selector check, which makes it timing-sensitive and causes it to never resolve because the page is already printed (and the printed page div removed) by then. This commit should fix the issue by activating the selector check as soon as possible, namely as soon as the viewer appears, which should ensure we're always registering the selector check in time because we're doing it even before rendering is starting.
|
I have been able to reproduce the Windows bot issues locally on Linux by introducing a delay (as small as 100-200 ms was already enough) before adding the /botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/63685f013e095b0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/332285bacfa7225/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/63685f013e095b0/output.txt Total script time: 5.43 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/332285bacfa7225/output.txt Total script time: 18.96 mins
|
|
/botio-windows integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/bc75438e9be89ca/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/bc75438e9be89ca/output.txt Total script time: 17.37 mins
|
|
/botio-windows integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/931ad77aec37d3b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/931ad77aec37d3b/output.txt Total script time: 19.37 mins
|
The Windows bot is usually slower than the Linux bot, and therefore text layer rendering is as well. However, the
autoprinttest awaited text layer rendering to complete before activating the selector check, which makes it timing-sensitive and causes it to never resolve because the page is already printed (and the printed page div removed) by then.This commit should fix the issue by activating the selector check as soon as possible, namely as soon as the viewer appears, which should ensure we're always registering the selector check in time because we're doing it even before rendering is starting.
Fixes #16965.