[Editor] Don't show the alt-text button when the alt-text dialog is visible

[calixteman]

This way, the button doens't cover the image.

[calixteman]

/botio-linux preview

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/140d5f6cf97d228/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/140d5f6cf97d228/output.txt

Total script time: 1.60 mins

Published

• Viewer: http://54.241.84.105:8877/140d5f6cf97d228/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/140d5f6cf97d228/legacy/web/viewer.html

[calixteman]

/botio-linux preview

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4cb68a2dc4660d2/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/4cb68a2dc4660d2/output.txt

Total script time: 1.57 mins

Published

• Viewer: http://54.241.84.105:8877/4cb68a2dc4660d2/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/4cb68a2dc4660d2/legacy/web/viewer.html

[Snuffleupagus]

Thinking about the "bigger picture" a little bit here: Would it make sense to instead only show the altText button when the StampEditor is hovered and/or focused?

[Dasha-Andriyenko]

@Snuffleupagus, while in editing mode, we'd want to show the alt text button even when not hovered/ focused. This is because we'd want to let users know when alt text has been added/ not added even just at a glance. This way, when a user is looking at all the photos, they can easily spot which ones have no alt text vs ones that do.

[Snuffleupagus]

One thing that I'd "worry" about with these changes is that if something goes wrong somewhere (e.g. if the dialog isn't opened as expected) we might end up with the altText-button being permanently hidden and thus inaccessible.
With that in mind, would it perhaps make sense to instead just forcibly set the small class on the altText-button while the dialog is open? It'd thus be moved "out" from the image, and not obscure it, but would be guaranteed to still be available.

[calixteman]

One thing that I'd "worry" about with these changes is that if something goes wrong somewhere (e.g. if the dialog isn't opened as expected) we might end up with the altText-button being permanently hidden and thus inaccessible. With that in mind, would it perhaps make sense to instead just forcibly set the small class on the altText-button while the dialog is open? It'd thus be moved "out" from the image, and not obscure it, but would be guaranteed to still be available.

If something goes wrong after the button is clicked and if one consequence is not having the button anymore, I'd say that it's probably the best way to have a bug report :).
That said if it really happens then why should we care about showing a button which is doing bad stuff ?

[Snuffleupagus]

r=me, with one more comment; thank you!

[calixteman]

/botio integrationtest

[calixteman]

/botio integrationtest

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7d00c97cc823493/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3fd8868fee1dce8/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/3fd8868fee1dce8/output.txt

Total script time: 5.65 mins

• Integration Tests: Passed

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/7d00c97cc823493/output.txt

Total script time: 16.72 mins

• Integration Tests: FAILED