Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct the correct field name and strip out classes when searching #16915

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

calixteman
Copy link
Contributor

@calixteman calixteman commented Sep 7, 2023

The classes were stripped out when creating the field name but it led to a wrong name.
Since class components in a path are irrelevant, they're just ignored when searching for a node in the datasets.

The classes were stripped out during when creating the field name but
it led to a wrong name.
Since class components in a path are irrelevant, they're just ignored
when searching for a node in the datasets.
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, assuming all tests pass; thank you!

@Snuffleupagus
Copy link
Collaborator

/botio xfatest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/925a11abfce0552/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6bee71373056fe6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/6bee71373056fe6/output.txt

Total script time: 10.15 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/6bee71373056fe6/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/925a11abfce0552/output.txt

Total script time: 22.10 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/925a11abfce0552/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 3e32d87 into mozilla:master Sep 7, 2023
3 checks passed
@calixteman calixteman deleted the issue16914 branch September 7, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotation fieldName not loaded correctly, part of the name containing "#subform" is ignored
3 participants