[Type-definitions] Fix type generator to support import maps #16890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
force-pushed
the
fix_type_generator
branch
from
d21eb2a
to
c958800
Compare
Some configurations settings like `paths` cannot be provided through CLI arguments but only in a configuration file. And when using a configuration file, only a few options (like `--outDir` can still be provided) through the CLI.
The typescript compiler is now configured to know about the import map to be able to resolve those imports and find the associated types. As tsc outputs declaration files using the original module identifiers and not the resolved ones, tsc-alias is used to post-process the declaration files by resolving those paths.
This reverts commit d9350c3.
stof
force-pushed
the
fix_type_generator
branch
from
c958800
to
46f2c58
Compare
Snuffleupagus
approved these changes
Sep 1, 2023
|
@Snuffleupagus is there any ETA for the next release that would ship non-broken types again ? As I'm new to this project, I don't know how the release schedule is managed. |
|
Nowadays releases usually happen on the last Sunday of every month, unless something unforeseen happens. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #16705 fully by making typescript aware of the import map when generating type declarations.