-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Add the possibility to create a new editor in using the keyboard (bug 1853424) #16761
[Editor] Add the possibility to create a new editor in using the keyboard (bug 1853424) #16761
Conversation
8e9883b
to
db41c69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay, this PR slipped my mind.
40a0818
to
552cc05
Compare
This comment was marked as outdated.
This comment was marked as outdated.
In this case you need to move the focus back to the freetext button and hit enter. |
…oard (bug 1853424) When an editing button is disabled, focused and the user press Enter (or space), an editor is automatically added at the center of the current page. Next creations can be done in using the same keys within the focused page.
552cc05
to
ea5eafa
Compare
Sorry, then I apparently misunderstood how all this was supposed to work :-) |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/139f209dbd7e7ec/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/139f209dbd7e7ec/output.txt Total script time: 1.40 mins Published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thanks!
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/77cebfc4605d44e/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c75102c28ff8a53/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c75102c28ff8a53/output.txt Total script time: 5.53 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/77cebfc4605d44e/output.txt Total script time: 26.08 mins
|
When an editing button is disabled, focused and the user press Enter (or space), an editor is automatically added at the center of the current page. Next creations can be done in using the same keys within the focused page.