Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @typedef JSDoc annotaion to fix typestest #16710

Closed
wants to merge 2 commits into from
Closed

Add @typedef JSDoc annotaion to fix typestest #16710

wants to merge 2 commits into from

Conversation

tamuratak
Copy link
Contributor

Add @typedef JSDoc annotaion to fix typestest. Close #16705

Snuffleupagus
Snuffleupagus requested changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already tried this in PR 16698 however it breaks gulp jsdoc.

@tamuratak
Copy link
Contributor Author

I have no idea how to work around it. Sorry.

@tamuratak tamuratak closed this Jul 19, 2023
@tamuratak tamuratak deleted the fix_typestest branch July 19, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request for help from TypeScript users] Re-enable gulp typestest in GitHub Actions
2 participants
@tamuratak @Snuffleupagus