[Editor] Support svg images in the stamp annotation

[calixteman]

createImageBitmap doesn't work with svg files (see bug 1841972), so we need to workaround this in using an Image.
When printing/saving we must rasterize the image, hence we get the biggest bitmap as image reference to avoid duplications or poor quality on rendering.

[Snuffleupagus]

Can you please add reference tests for this, e.g. copying these existing ones and using svg-files for the images, since these changes aren't really covered by existing tests?

[calixteman]

Can you please add reference tests for this, e.g. copying these existing ones and using svg-files for the images, since these changes aren't really covered by existing tests?

The problem is that we always pass a bitmap to the worker and these tests only test saving/printing.
The only way to test that stuff would be to have an integration test which will add a svg, then we should make a screenshot and finally compare it to a reference.... It'd be really nice to have.

[calixteman]

Something else we could try is to make an integration test and at some save the pdf but in using directly the api to get the saved stream, then parse the result and finally check that everything is ok: it'd be a mix of integration test and unit test. Wdyt ?

[Snuffleupagus]

Something else we could try is to make an integration test and at some save the pdf but in using directly the api to get the saved stream, then parse the result and finally check that everything is ok: it'd be a mix of integration test and unit test. Wdyt ?

If that works without too much trouble, then it sounds like a good idea!

[calixteman]

It's easy to get the bytes buffer from a saved pdf but it's more complex to parse it.
So I just tested that editors and the serialized images have the correct dimensions (which means that the image behind is the correct one).

[Snuffleupagus]

r=me, with the comment addressed; thank you!

[calixteman]

/botio integrationtest

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/28257170328eab0/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c931795028f38e4/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/c931795028f38e4/output.txt

Total script time: 3.96 mins

• Integration Tests: Passed

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/28257170328eab0/output.txt

Total script time: 26.42 mins

• Integration Tests: FAILED