Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search in pdf a containing some UTF-32 characters (bug 1820909) #16138

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

calixteman
Copy link
Contributor

Some chars were supposed to have a length equals to 1 but UTF-32 chars can be longuer.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

test/unit/pdf_find_controller_spec.js Outdated Show resolved Hide resolved
Some chars were supposed to have a length equals to 1 but UTF-32 chars
can be longuer.
@calixteman
Copy link
Contributor Author

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2023

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dd9ff34de23e49a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2023

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/dd9ff34de23e49a/output.txt

Total script time: 2.52 mins

  • Unit Tests: Passed

@calixteman
Copy link
Contributor Author

/botio-windows unittest

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2023

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5ebed184be1fd48/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2023

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/4d7a7a5a8d49f9c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2023

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/5ebed184be1fd48/output.txt

Total script time: 10.82 mins

  • Unit Tests: FAILED

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2023

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/4d7a7a5a8d49f9c/output.txt

Total script time: 11.55 mins

  • Unit Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2023

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/973f40eb4ce6eb2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2023

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/02613c6d9928d51/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2023

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/973f40eb4ce6eb2/output.txt

Total script time: 4.72 mins

  • Integration Tests: FAILED

@pdfjsbot
Copy link

pdfjsbot commented Mar 9, 2023

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/02613c6d9928d51/output.txt

Total script time: 18.20 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 0338df2 into mozilla:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants