Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rewriteUrlClosure into the web/chromecom.js file #16028

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

Given that this is only used for the Chrome-addon, we can move this code into the relevant file instead.

Given that this is only used for the Chrome-addon, we can move this code into the relevant file instead.
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ba80e93cb87c806/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/042857d2319a1f4/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/ba80e93cb87c806/output.txt

Total script time: 4.39 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/042857d2319a1f4/output.txt

Total script time: 11.99 mins

  • Integration Tests: FAILED

@timvandermeij timvandermeij merged commit ddf05b0 into mozilla:master Feb 11, 2023
@timvandermeij
Copy link
Contributor

Looks good!

@Snuffleupagus Snuffleupagus deleted the move-CHROME-rewriteUrlClosure branch February 11, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants