[api-minor] Update the minimum supported browsers, and remove the PostCSS logical plugin
#15968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
rm-postCSS-logical
branch
2 times, most recently
from
02693e3
to
a617fe5
Compare
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/12ee0cae18cc964/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8aa83dd9f2e3069/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/8aa83dd9f2e3069/output.txt Total script time: 4.88 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/12ee0cae18cc964/output.txt Total script time: 13.13 mins
|
…tCSS `logical` plugin The patch updates the minimum supported browsers/environments as follows: - Chrome 87, which was released on 2020-11-17; see https://en.wikipedia.org/wiki/Google_Chrome_version_history - Firefox ESR (no change); see https://wiki.mozilla.org/Release_Management/Calendar - Safari 14.1, which was released on 2021-04-26; see https://en.wikipedia.org/wiki/Safari_version_history#Safari_14 - Node.js 14 (no change); see https://en.wikipedia.org/wiki/Node.js#Releases The recent *major* release of the PostCSS `logical` plugin effectively removed support for all of the things that we used it for, which includes (but may not be limited to): preserving the original CSS code (for up-to-date browsers), re-writing the `:dir` pseudo-class, and support for re-writing `float: inline-start;`/`float: inline-end;` properties. Please find additional details at https://github.com/csstools/postcss-plugins/blob/main/plugins/postcss-logical/CHANGELOG.md#600-january-24-2023 Hence the primary reason for these changes are related to native support for *logical* CSS properties/values. Currently, in the default viewer, we're using the following ones: - https://developer.mozilla.org/en-US/docs/Web/CSS/inset-inline-start#browser_compatibility - https://developer.mozilla.org/en-US/docs/Web/CSS/inset-inline-end#browser_compatibility - https://developer.mozilla.org/en-US/docs/Web/CSS/margin-inline-start#browser_compatibility - https://developer.mozilla.org/en-US/docs/Web/CSS/margin-inline-end#browser_compatibility - https://developer.mozilla.org/en-US/docs/Web/CSS/padding-inline-start#browser_compatibility - https://developer.mozilla.org/en-US/docs/Web/CSS/padding-inline-end#browser_compatibility - https://developer.mozilla.org/en-US/docs/Web/CSS/text-align#browser_compatibility - https://developer.mozilla.org/en-US/docs/Web/CSS/float#browser_compatibility By updating the minimum supported browsers, we thus only have to worry about the *last* case here. Thankfully there's not that many `float: inline-start;`/`float: inline-end;` occurrences, and we can utilize CSS variables together with the pre-processor to support those in a way that won't affect the Firefox PDF Viewer.
Snuffleupagus
force-pushed
the
rm-postCSS-logical
branch
from
a617fe5
to
ca996d2
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f0159a2430f2e02/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f0159a2430f2e02/output.txt Total script time: 1.38 mins Published |
timvandermeij
approved these changes
Feb 4, 2023
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch updates the minimum supported browsers/environments as follows:
The recent major release of the PostCSS
logicalplugin effectively removed support for all of the things that we used it for, which includes (but may not be limited to): preserving the original CSS code (for up-to-date browsers), re-writing the:dirpseudo-class, and support for re-writingfloat: inline-start;/float: inline-end;properties. Please find additional details at https://github.com/csstools/postcss-plugins/blob/main/plugins/postcss-logical/CHANGELOG.md#600-january-24-2023Hence the primary reason for these changes are related to native support for logical CSS properties/values. Currently, in the default viewer, we're using the following ones:
By updating the minimum supported browsers, we thus only have to worry about the last case here. Thankfully there's not that many
float: inline-start;/float: inline-end;occurrences, and we can utilize CSS variables together with the pre-processor to support those in a way that won't affect the Firefox PDF Viewer.