Update highlight background when forced colors are active (bug 1759886) #15921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchasen
force-pushed
the
forced-colors-highlights
branch
from
596e114
to
0a6b1cd
Compare
fchasen
changed the title
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/528769321156757/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/528769321156757/output.txt Total script time: 1.22 mins Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When forced color are active this updates the background of highlights to use CSS system colors, so Windows HCM mode will pick a highlight color that strongly contrasts the text.
Ideally we could add outlines for highlights and remove the background to provide better contrast, but I don't think this is possible without
forced-color-adjust: noneorcolor: transparentsupport.