Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect a few additional DOM element accesses in the viewer (PR 15831 follow-up) #15835

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

A couple of cases that I missed during review, for code-paths that don't run by default in the viewer.

… follow-up)

A couple of cases that I missed during review, for code-paths that don't run by default in the viewer.
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4ae70b7a429b81c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4cde676a55fc74a/output.txt

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/4cde676a55fc74a/output.txt

Total script time: 4.29 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/4ae70b7a429b81c/output.txt

Total script time: 9.96 mins

  • Integration Tests: FAILED

@Snuffleupagus Snuffleupagus merged commit b518d93 into mozilla:master Dec 15, 2022
@Snuffleupagus Snuffleupagus deleted the viewer-safe-element-access branch December 15, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants